[
https://issues.apache.org/jira/browse/OFBIZ-6705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17283255#comment-17283255 ]
Michael Brohl commented on OFBIZ-6705:
--------------------------------------
Removing affects versions except trunk because this is an improvement (no bug).
> some files set viewIndex to 1 by default rather than 0
> ------------------------------------------------------
>
> Key: OFBIZ-6705
> URL:
https://issues.apache.org/jira/browse/OFBIZ-6705> Project: OFBiz
> Issue Type: Improvement
> Affects Versions: Trunk
> Reporter: Gareth Carter
> Assignee: Michael Brohl
> Priority: Minor
> Attachments: OFBIZ-6705.patch, OFBIZ-6705.patch, OFBIZ-6705_2020.patch, OFBIZ-6705_sample.patch
>
>
> The following files set viewIndex to 1
> {noformat}
> ./applications/order/src/org/ofbiz/order/order/OrderLookupServices.java: if (viewIndex == null) viewIndex = 1;
> ./applications/order/webapp/ordermgr/entry/catalog/categorydetail.ftl: <#--assign viewIndex = viewIndex - 1/-->
> ./applications/order/webapp/ordermgr/WEB-INF/actions/order/FindOrders.groovy:viewIndex = request.getParameter("viewIndex") ? Integer.valueOf(request.getParameter("viewIndex")) : 1;
> ./applications/party/webapp/partymgr/WEB-INF/actions/communication/ListCommunications.groovy:context.viewIndex = 1;
> ./applications/party/webapp/partymgr/WEB-INF/actions/visit/ShowVisits.groovy: viewIndex = Integer.valueOf(parameters.VIEW_INDEX ?: 1);
> ./specialpurpose/ecommerce/webapp/ecommerce/WEB-INF/actions/shoppinglist/EditShoppingList.groovy: viewIndex = Integer.valueOf(parameters.VIEW_INDEX ?: 1);
> {noformat}
> I ran this command to get the output:
> grep -R --exclude-dir=.svn "viewIndex = " . | grep " 1"
> As far as I am aware, viewIndex starts from 0
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
Locked
