[jira] [Commented] (OFBIZ-6759) Improves HTTP header

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-6759) Improves HTTP header

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-6759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15050259#comment-15050259 ]

Jacques Le Roux commented on OFBIZ-6759:
----------------------------------------

You must be tired, I removed not added ;)

http://svn.apache.org/viewvc/ofbiz/trunk/themes/bizznesstime/includes/header.ftl?r1=1718864&r2=1718863&pathrev=1718864

Please read the commit comment!
{quote}
According to http://www.w3.org/International/questions/qa-http-and-lang Content-Language should not be used, moreover why only "en"?

This is part of a work for "Improves HTTP header" https://issues.apache.org/jira/browse/OFBIZ-6759

This is a 1st step. I will check if all the other http-equiv metas of bizznesstime/includes/header.ftl are still recommended/useful and move/refactor/enhance/improve them as a basis for a new header FTL template to create in framework/image and to include it "where needed"
{quote}

Your remark about the language is interesting, for your education please follow how docLangAttr is created...

> Improves HTTP header
> --------------------
>
>                 Key: OFBIZ-6759
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-6759
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework, themes
>    Affects Versions: Trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Minor
>
> After looking at https://cyh.herokuapp.com/cyh and https://www.owasp.org/index.php/List_of_useful_HTTP_headers and checking what we currently use as/in HTTP header fields in themes and other places I think it's time to update the header.
> The idea is to create a new header FTL template in framework/image and to include it "where needed" and possibly refactor what currently exist.
> As there are many ways to define "where needed". I decided to keep things simple. There are (case insensitive) 324 occurences of "<head>", 112 occurences of "<html" but only 16 occurences of "<html lang=" and only 12 in FTL templates (others are in jQuery files)
> Most of the 112 occurences of "<html" belong to email templates. So I will focus on the not email templates cases among the 12 in FTL templates.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)