[jira] [Commented] (OFBIZ-6777) Product weight field enhancements

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-6777) Product weight field enhancements

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-6777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15065235#comment-15065235 ]

Suraj Khurana commented on OFBIZ-6777:
--------------------------------------

Copying Jacopo's comment from dev list:
================================
There are indeed some data model inconsistencies in this area.
After reviewing the commit (817605) that introduced the field productWeight
I think that the following applies:
"weight" should be used to specify the "shipping weight" of the product
"productWeight" should be used to specify the actual weight of the product.

However since its introduction, productWeight was never used and "weight"
has been used both to specify the shipping weight and to specify the actual
weight.

How can we fix this situation? I see two options:
1) review all usages of "weight" and fix according to the definition above
2) rename "productWeight" into "shippingWeight" and fix the codebase to use
this field only when the shipping weight is required and use "weight" in
all the other cases.

Maybe #2 would be easier to implement and would have a limited impact on
existing instances.
===========================

> Product weight field enhancements
> ---------------------------------
>
>                 Key: OFBIZ-6777
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-6777
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: product
>    Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk
>            Reporter: Suraj Khurana
>
> There are three sets of dimensions in the Product entity.
> (productHeight, shippingHeight), (productWidth,  shippingWidth), (productDepth, shippingDepth) but in case of weight, there is another set of dimension field weight and productWeight which are inconsistent in nature.
> Fix this thing and correct all instances of this in the framework.
>  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)