[jira] [Commented] (OFBIZ-6782) Service parameter should be required.

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-6782) Service parameter should be required.

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-6782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15076406#comment-15076406 ]

Scott Gray commented on OFBIZ-6782:
-----------------------------------

Are you sure you're using the 14.12 release?  Because it appears to have been fixed already in that branch:
Diff: http://svn.apache.org/viewvc/ofbiz/branches/release14.12/applications/accounting/src/org/ofbiz/accounting/tax/TaxAuthorityServices.java?r1=1511742&r2=1534062
Commit: http://svn.apache.org/viewvc?view=revision&revision=1534062

> Service parameter should be required.
> -------------------------------------
>
>                 Key: OFBIZ-6782
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-6782
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: Release Branch 14.12
>            Reporter: Kulwant Singh
>
> There is no null check on one of parameters "itemShippingList" of calcTax service implemented in TaxAuthorityServices.java by name of rateProductTaxCalc.
> Now this parameter should either be made required in service defination in services_tax.xml or null check should be present just like the other parameters like itemQuantity have.
> because when i am trying to run this service with only passing required parameters it is throwing null pointer exception.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)