[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15264155#comment-15264155 ]
Taher Alkhateeb commented on OFBIZ-6783:
----------------------------------------
Hi Jacopo,
I was thinking that something else might need the commons-cli in the framework and so preferred keeping it in base. But anyway, no problem I can keep it in start. Either way, I need to modify start's build.xml to include the class-path in the jar construction otherwise it will not work (because ofbiz.jar is _copied_ to root)
Since you opened this subject up anyway, the radical idea I have in mind is to actually (more or less) eliminate the idea of components entirely in /framework. I think the framework should be one independent thing that loads other components. Anyway, I will compile my thoughts on this and discuss it at a later stage on the mailing list in the future.
> Refactor start.java
> -------------------
>
> Key: OFBIZ-6783
> URL:
https://issues.apache.org/jira/browse/OFBIZ-6783> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: Upcoming Branch
> Reporter: Taher Alkhateeb
> Assignee: Taher Alkhateeb
> Labels: framework, main, refactoring, start
> Attachments: OFBIZ-6783.patch
>
>
> Looking at the main method and design of Start.java looks ugly. The things I would like to fix so far are:
> - the file is too long
> - some variables are not even needed (loaderArgs?)
> - the level of abstraction is wrong
> - main throws an exception!
> - the arguments processing logic is terrible, need to move it to commons-cli
> It's just so messy and ugly to look at. So for me refactoring starts at Start! Given that this is an important file, I will provide a patch to be reviewed by the community before committing just to be on the safe side.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Locked
