[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15282693#comment-15282693 ]
Jacques Le Roux commented on OFBIZ-6783:
----------------------------------------
I see no difference between
java -jar ofbiz.jar --batch
and
java -jar ofbiz.jar --start
This is what you get when you use
ant start-batch
on Win7
{code}
C:\projectASF-Mars\ofbiz>ant start-batch
"C:\Program Files\Java\jdk1.8.0_74\bin\java" -jar "C:\projectASF-Mars\ofbiz\framework\base\lib\ant-1.9.0-ant-launcher.jar" -lib "C:\projectASF-Mars\ofbiz\framework\base\lib\ant" start-batch
Buildfile: C:\projectASF-Mars\ofbiz\build.xml
start-batch:
BUILD SUCCESSFUL
Total time: 1 second
{code}
> Refactor start.java
> -------------------
>
> Key: OFBIZ-6783
> URL:
https://issues.apache.org/jira/browse/OFBIZ-6783> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: Upcoming Branch
> Reporter: Taher Alkhateeb
> Assignee: Taher Alkhateeb
> Labels: framework, main, refactoring, start
> Attachments: OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, StartCommandUtil.java
>
>
> Looking at the main method and design of Start.java looks ugly. The things I would like to fix so far are:
> - the file is too long
> - some variables are not even needed (loaderArgs?)
> - the level of abstraction is wrong
> - main throws an exception!
> - the arguments processing logic is terrible, need to move it to commons-cli
> It's just so messy and ugly to look at. So for me refactoring starts at Start! Given that this is an important file, I will provide a patch to be reviewed by the community before committing just to be on the safe side.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Locked
