[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15290645#comment-15290645 ]
Jacques Le Roux commented on OFBIZ-6783:
----------------------------------------
Ah indeed, anyway same with
bq. java -jar ofbiz.jar --test component=minilang
BTW when running
bq. java -jar ofbiz.jar test
with your commit reverted (so old way)
I get this at some point
{code}
2016-05-19 09:46:43,169 |main |TestRunContainer |I| [JUNIT] Pass: true | # Tests: 5 | # Failed: 0 # Errors: 0
org.ofbiz.base.start.StartupException: Cannot start() org.ofbiz.testtools.TestRunContainer (Test run was unsuccessful)
at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:239)
at org.ofbiz.base.start.Start.startStartLoaders(Start.java:446)
at org.ofbiz.base.start.Start.start(Start.java:191)
at org.ofbiz.base.start.Start.main(Start.java:88)
Caused by: org.ofbiz.base.container.ContainerException: Test run was unsuccessful
at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:193)
at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:237)
... 3 more
Exception in thread "main" org.ofbiz.base.start.StartupException: java.lang.Exception: Error during start. (Error during start.)
at org.ofbiz.base.start.Start.main(Start.java:91)
Caused by: java.lang.Exception: Error during start.
at org.ofbiz.base.start.Start.start(Start.java:195)
at org.ofbiz.base.start.Start.main(Start.java:88)
{code}
And then it's blocked. Anyway we don't care now... so just to say...
> Refactor the start component
> ----------------------------
>
> Key: OFBIZ-6783
> URL:
https://issues.apache.org/jira/browse/OFBIZ-6783> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: Upcoming Branch
> Reporter: Taher Alkhateeb
> Assignee: Taher Alkhateeb
> Labels: framework, main, refactoring, start
> Attachments: OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, StartCommandUtil.java
>
>
> Looking at the main method and design of Start.java and the start component overall looks ugly. The things I would like to fix so far are:
> - the files are too long
> - some variables are not even needed (loaderArgs?)
> - the level of abstraction is wrong
> - main throws an exception!
> - the arguments processing logic is terrible, need to move it to commons-cli
> It's just so messy and ugly to look at. So for me refactoring starts at Start! Given that this is an important component, I will provide a patch to be reviewed by the community before committing just to be on the safe side.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Locked
