[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15318225#comment-15318225 ]
Taher Alkhateeb commented on OFBIZ-6783:
----------------------------------------
Hi Jacques,
I always feel extra assured after you pitch in. Your QA work is something inspiring :)
Anyway, based on your feedback:
- already renamed all instanced to AdminServer and AdminClient and updated docs
- Not sure what you mean by adding a comment for ofbiz.admin.port. That's just the property key to fetch the value from in the relevant java properties file. Are you referring to Config.java or the start.properties file or what?
- I would not worry too much about the details of adaptStartupCommandsToLoaderArgs in StartupControlPanel. My intention is to eventually delete this method completely while also changing the signature of the system containers. This is just a hack to make OFBiz work while switching from String[] to List<StartupCommand>
- I removed the prefixes, good eyes :) thank you.
- It seems the shutting down issue on start-both is due to buggy code outside start. Shutting down the system in the old days with status FAIL means there is a problem. It could be some shutdown sequence in POS or something in the containers, nobody should execute start or shutdown stuff other than the start component. Anyway, I'd rather push that to another day given that the system is functional and we are still heavily refactoring.
On a side note, I find POS a very annoying component. It's right there in the options of the startup sequence. That's just wrong, it should be another deployable component or alternatively a stand alone application. It should not live inside OFBiz on the startup sequence.
I will commit everything soon.
> Refactor the start component
> ----------------------------
>
> Key: OFBIZ-6783
> URL:
https://issues.apache.org/jira/browse/OFBIZ-6783> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: Upcoming Branch
> Reporter: Taher Alkhateeb
> Assignee: Taher Alkhateeb
> Labels: framework, main, refactoring, start
> Attachments: OFBIZ-6783-hiddenfiles.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, StartCommandUtil.java, error.log, ofbiz.log
>
>
> Looking at the main method and design of Start.java and the start component overall looks ugly. The things I would like to fix so far are:
> - the files are too long
> - some variables are not even needed (loaderArgs?)
> - the level of abstraction is wrong
> - main throws an exception!
> - the arguments processing logic is terrible, need to move it to commons-cli
> It's just so messy and ugly to look at. So for me refactoring starts at Start! Given that this is an important component, I will provide a patch to be reviewed by the community before committing just to be on the safe side.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Locked
