[jira] [Commented] (OFBIZ-6920) Credit card details cannot be updated

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-6920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15187568#comment-15187568 ]

Jacques Le Roux commented on OFBIZ-6920:
----------------------------------------

OK I had a look. The problem is we are calling createCreditCard map proc from updateCreditCard service after calling updateCreditCard map proc. And when we update the data we don't see the real card number but something like "************1111"

Since we don't want to change createCreditCard map proc and I see no simple way to detect if we should or not use isAnyCard call in createCreditCard map proc depending on where it's called (creating or updating) I will simply copy the needed check from createCreditCard map proc into updateCreditCard map proc but not the isAnyCard call of course.  Then it will work but if the user changes also the card number. If she does it will need to be right because it will not be checked! I can't see any other ways because we can't use a hidden field with the real card number in, it would be insecure. We could thouhg introduce a specific encryption/decryption but it seems a bit too much.

If somebody has a better idea please tell, before I commit the change I propose...

> Credit card details cannot be updated
> -------------------------------------
>
>                 Key: OFBIZ-6920
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-6920
>             Project: OFBiz
>          Issue Type: Bug
>          Components: party
>            Reporter: Vyom Jain
>            Assignee: Jacques Le Roux
>
> It seems after OFBIZ-3956, credit card details can no longer be updated, for example, if one wishes to update the expiry date of a credit card
> results in following "The Following Errors Occurred: Card Number is erroneous".
> This issue can be replicated here - https://demo-trunk-ofbiz.apache.org/partymgr/control/editcreditcard?paymentMethodId=9015&partyId=DemoCustomer

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)