[
https://issues.apache.org/jira/browse/OFBIZ-6931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15241839#comment-15241839 ]
Jacques Le Roux commented on OFBIZ-6931:
----------------------------------------
I did not review all details, nice piece of code at 1st glance.
A small question: is it on purpose that
{code}
- <field name="searchButton" title="${uiLabelMap.CommonFind}" widget-style="smallSubmit"><submit button-type="button" image-location="/images
/icons/magnifier.png"/></field>
{code}
has been replaced by
{code}
+ <field name="searchButton" position="1"><submit/></field>
{code}
?
I'm not against, just wondering because maybe we could harmonize everywhere?
For
{code}
<value xml:lang="en">View as spread</value>
{code}
Why not rather?
{code}
<value xml:lang="en">View as spreadsheet</value>
{code}
Not sure why, I did not see the corresponding button
{code}
<link target="ExampleReportXls" text="${uiLabelMap.CommonViewAsXls}" style="buttontext">
<parameter param-name="exampleId"/>
</link>
{code}
But I must say it's late, so I did not dig further
> Add XLS renderer
> ----------------
>
> Key: OFBIZ-6931
> URL:
https://issues.apache.org/jira/browse/OFBIZ-6931> Project: OFBiz
> Issue Type: New Feature
> Components: ALL COMPONENTS, framework
> Affects Versions: Trunk
> Reporter: Leila Mekika
> Assignee: Nicolas Malin
> Priority: Minor
> Attachments: OFBIZ-6931.patch, Sélection_154.png, xls-renderer.patch
>
>
> Add a new renderer type in order to enable XLS file output.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Locked
