[
https://issues.apache.org/jira/browse/OFBIZ-6944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15239884#comment-15239884 ]
Jacques Le Roux commented on OFBIZ-6944:
----------------------------------------
This TODO is there for more than 9 years, so I guess it's time to do it.
Your changes are OK with me (I only reviewed the patch, i did not apply completly). I agree it's a bit awkward, but I see no better ways, not the only time Java is verbose ;)
We could use Files.readAllBytes(file.toPath()) instead of FileUtils.readFileToByteArray(file) but that does not change much...
> streamDataResource do not manage OTHER_OBJECT dataResourceTypeId
> ----------------------------------------------------------------
>
> Key: OFBIZ-6944
> URL:
https://issues.apache.org/jira/browse/OFBIZ-6944> Project: OFBiz
> Issue Type: Bug
> Components: content
> Affects Versions: Trunk
> Reporter: Gil Portenseigne
> Assignee: Gil Portenseigne
> Attachments: OFBIZ-6944.patch
>
>
> When using request ViewBinaryDataResource?dataResourceId=10015 with a OTHER_OBJECT dataResourceTypeId, we meet the error :
> {quote}org.ofbiz.webapp.view.ViewHandlerException: The dataResourceTypeId [OTHER_OBJECT] is not supported in streamDataResource{quote}
> This is relative to an existing TODO in DataResourceWorker.java :
> {code}// TODO: remove this method in favor of getDataResourceStream {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Locked
