[
https://issues.apache.org/jira/browse/OFBIZ-6986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15226004#comment-15226004 ]
Pranay Pandey commented on OFBIZ-6986:
--------------------------------------
Hi Kulwant,
Thanks for the effort and providing patch for the improvement you are making.
Should we change this issue type to Improvement instead of calling it a bug or if it's a bug, you will need to provide more details in issue description.
Please make sure you have attached the correct *.patch file. In its current state, it won't work or get applied on committers working copy.
Also for naming the patch file you can simply follow the practice to use OFBiz JIRA Ticket Id e.g. in this case you can name your patch file as OFBIZ-6986.patch
You can keep on adding revised version of patches based on improvement suggestions with the same name, JIRA will take care of versioning those patch files with same names and it's easy to identify the latest one.
Thanks!
> Simplify getChildHRCategoryTree
> -------------------------------
>
> Key: OFBIZ-6986
> URL:
https://issues.apache.org/jira/browse/OFBIZ-6986> Project: OFBiz
> Issue Type: Bug
> Components: ALL APPLICATIONS, humanres
> Reporter: Kulwant
> Attachments: 0001-refactor-getChildHRCategoryTree-in-humanres.patch
>
>
> breaking the single long method to multiple private functions with improved exception handling.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Locked
