[
https://issues.apache.org/jira/browse/OFBIZ-6986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15229781#comment-15229781 ]
Pranay Pandey commented on OFBIZ-6986:
--------------------------------------
Hi Kulwant,
Thanks for the updated patch. Please refer, review and follow - [OFBiz Contributors Best Practices|
https://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+Contributors+Best+Practices]
Tried applying the patch for review and verification. It looks like it still has issues. Here is the log you can refer.
Quickly looking at patch also reveals some formatting fixes as well. Always functional part of changes or improvement being done should go separately(not including formatting fixes in core work). Formatting fixes can be done in a later commit.
{quote}
ofbiz pranaypandey$ patch -p0 < ~/Desktop/OFBIZ-6986.patch
The next patch would delete the file a/applications/humanres/config/HumanResErrorUiLabels.xml,
which does not exist! Assume -R? [n] n
Apply anyway? [n] n
Skipping patch.
1 out of 1 hunk ignored
can't find file to patch at input line 35
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/applications/humanres/ofbiz-component.xml b/applications/humanres/ofbiz-component.xml
|index 089e49e..cc8ca33 100644
|--- a/applications/humanres/ofbiz-component.xml
|+++ b/applications/humanres/ofbiz-component.xml
--------------------------
File to patch:
{quote}
> Simplify getChildHRCategoryTree
> -------------------------------
>
> Key: OFBIZ-6986
> URL:
https://issues.apache.org/jira/browse/OFBIZ-6986> Project: OFBiz
> Issue Type: Improvement
> Components: ALL APPLICATIONS, humanres
> Reporter: Kulwant
> Assignee: Pranay Pandey
> Attachments: OFBIZ-6986.patch
>
>
> breaking the single long method to multiple private functions with improved exception handling.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Locked
