[jira] [Commented] (OFBIZ-6986) Simplify getChildHRCategoryTree

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-6986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15230148#comment-15230148 ]

Taher Alkhateeb commented on OFBIZ-6986:
----------------------------------------

One more thing to add to my above comments:

Please add testing to your code! A minimum of two or three tests are needed IMHO

> Simplify getChildHRCategoryTree
> -------------------------------
>
>                 Key: OFBIZ-6986
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-6986
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL APPLICATIONS, humanres
>            Reporter: Kulwant
>            Assignee: Pranay Pandey
>             Fix For: Upcoming Branch
>
>         Attachments: OFBIZ-6986.patch, OFBIZ-6986.patch
>
>
> breaking the single long method to multiple private functions with improved exception handling.

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)