[
https://issues.apache.org/jira/browse/OFBIZ-6990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15236709#comment-15236709 ]
Gil Portenseigne commented on OFBIZ-6990:
-----------------------------------------
Hi James,
I tested you patch with OFBIZ-4090.patch, it works fine for me.
Concerning you patch, there are some formatting issues. The xml part contains lots of tabs, it's best to follow OFBiz coding convention
https://cwiki.apache.org/confluence/display/OFBADMIN/Coding+Conventions , using 4 spaces for indentation. You add some uneeded empty lines (for example in controller.xml part).
Nothing More, it's working like a charm, is there something blocking commiting OFBIZ-4090 ? i didn't review it in details...
> Add Example for Compound Screen Widget
> --------------------------------------
>
> Key: OFBIZ-6990
> URL:
https://issues.apache.org/jira/browse/OFBIZ-6990> Project: OFBiz
> Issue Type: Improvement
> Components: specialpurpose/example
> Affects Versions: Trunk
> Reporter: james yong
> Priority: Minor
> Attachments: OFBIZ-6990.patch
>
>
> An example to test out Compound Screen Widget
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Locked
