[
https://issues.apache.org/jira/browse/OFBIZ-6990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15239458#comment-15239458 ]
Jacques Le Roux commented on OFBIZ-6990:
----------------------------------------
Thanks for the review Gil,
{quote}
is there something blocking commiting OFBIZ-4090 ? i didn't review it in details...
{quote}
Yes there were some issues, it was not really complete. At revision: 1738958 I put in trunk all OFBIZ-4090 and OFBIZ-6990 changes refactored and I will close OFBIZ-4090 with OFBIZ-6990. I think we could do a better example, but that would be another Jira!
Here are the changes globally
# As James mentionned we no longer need *-v2.xsd files, I removed them from Adrian's patch
# I created a compound-widgets.xsd based on Adrian's and James Yong's previous work. From Paul Foxworthy's comment in OFBIZ-4090, I decided to name the root compound-widgets (hence the file name). I arranged its elements in another way, see below with ExampleCompoundWidgets.xml
# I slightly modified James Yong's ExampleCompoundScreenWidget.xml file and renamed it ExampleCompoundWidgets.xml. I added an "s" because there are several OFBiz widgets gathered in one place. For the modifications: I simply changed the names and arranged the elements in another way which I find better suited. I'm used to 1st create the query, then the menus, the screens and their forms. We rarely use widget-trees but it's there also. Finally the simple-method at end if any. The order is not enforced though, so everybody can use her/his own
# I added a French label
# I completed the widget-catalog.xml with this new entry and tested locally in Eclipse by reloading the XML catalog entries.
> Add Example for Compound Screen Widget
> --------------------------------------
>
> Key: OFBIZ-6990
> URL:
https://issues.apache.org/jira/browse/OFBIZ-6990> Project: OFBiz
> Issue Type: Improvement
> Components: specialpurpose/example
> Affects Versions: Trunk
> Reporter: james yong
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-6990.patch, OFBIZ-6990.patch
>
>
> An example to test out Compound Screen Widget
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Locked
