[
https://issues.apache.org/jira/browse/OFBIZ-7040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15565164#comment-15565164 ]
Jacopo Cappellato commented on OFBIZ-7040:
------------------------------------------
I confirm that I have solely focused my work on the switch from Javolution parser to the default SAX parser.
While there is still a lot of room for improvements, I am not sure that we should create an interface: the current design is essentially the one recommended by the Oracle Javadocs (implement a custom SAX Handler that extends the abstract DefaultHandler which in turns implements the ContentHandler and ErrorHandler interfaces.
Maybe we should rename this class to EntitySaxHandler and move the parse(...) methods into a client class that create an instance of the parser, pass the an instance of EntitySaxHandler to it and perform the parsing.
However this is probably a minor thing and we could consider to resolve this ticket for now.
> Redesign EntitySaxReader
> ------------------------
>
> Key: OFBIZ-7040
> URL:
https://issues.apache.org/jira/browse/OFBIZ-7040> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: Upcoming Branch
> Reporter: Martin Becker
> Assignee: Michael Brohl
> Priority: Minor
>
> org.ofbiz.entity.util.EntitySaxReader requires refactoring to achieve the following goals
> Refactor EntitySaxReader to an interface
> Create an implementing class
> Remove all dependencies on Javolution
> Fix all dependencies in the framework to match the new signature of the interface
> Delete the javolution library from the framework
> Taken from the Refactor ToDo list at
https://cwiki.apache.org/confluence/display/OFBIZ/Re-Factor+To-Do+List--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Locked
