[jira] [Commented] (OFBIZ-7061) Autocompletion for Compound Widget

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-7061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15345198#comment-15345198 ]

Jacques Le Roux commented on OFBIZ-7061:
----------------------------------------

I don't like 1, 2 seems simple and 3 more elegant and brings consistency, but not that much because we have still a bunch of other XSDs which are not using namespaces.

For the sake of simplicity and remembering, here are the necessary changes for option 2
h3. XSD
{code}
Index: framework/minilang/dtd/simple-methods.xsd
===================================================================
--- framework/minilang/dtd/simple-methods.xsd (revision 1749654)
+++ framework/minilang/dtd/simple-methods.xsd (working copy)
@@ -17,7 +17,7 @@
 specific language governing permissions and limitations
 under the License.
 -->
-<xs:schema xmlns:xs="http://www.w3.org/2001/XMLSchema" elementFormDefault="qualified" xmlns="http://ofbiz.apache.org/Simple-Method" targetNamespace="http://ofbiz.apache.org/Simple-Method">
+<xs:schema xmlns:xs="http://www.w3.org/2001/XMLSchema" elementFormDefault="qualified">
 <!--
     ==================================================
     ========== The Simple Methods Section ==========
{code}

h3. An example for XML
{code}
Index: applications/party/minilang/communication/CommunicationEventServices.xml
===================================================================
--- applications/party/minilang/communication/CommunicationEventServices.xml (revision 1749654)
+++ applications/party/minilang/communication/CommunicationEventServices.xml (working copy)
@@ -19,9 +19,8 @@
 -->

 <simple-methods xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-       xmlns="http://ofbiz.apache.org/Simple-Method" xsi:schemaLocation="http://ofbiz.apache.org/Simple-Method http://ofbiz.apache.org/dtds/simple-methods.xsd">
+              xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/simple-methods.xsd">
{code}

But then we still need to "duplicate" simple-methods.xsd in simple-methods-ns.xsd as we did, to get the simple-method namespace for compound-widgets

So I'd try 3 first and if it's really too hard, then 2, at least temporary, other opinions?

> Autocompletion for Compound Widget
> ----------------------------------
>
>                 Key: OFBIZ-7061
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-7061
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Trunk
>            Reporter: james yong
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: Upcoming Branch
>
>         Attachments: OFBIZ-7061.patch, OFBIZ-7061.patch, OFBIZ-7061.patch
>
>
> I am trying to enable auto-completion when coding compound widget.
> My plan as follows:
> 1. The following xsd will be modified to use namespace
> site-conf.xsd
> widget-form.xsd
> widget-screen.xsd
> widget-menu.xsd
> simple-methods.xsd
> For example, in site-conf.xsd, we add the following document level attribute
> {code}
> xmlns="http://ofbiz.apache.org/sc" targetNamespace="http://ofbiz.apache.org/sc"
> {code}
> 2. Import the above schema into compound-widgets.xsd so that compound widgets use only one consolidated schema.
> 3. Update ExampleCompoundWidgets.xml to use the new compound-widgets.xsd. For example
> {code}
> <compound-widgets xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
>         xmlns:sc="http://ofbiz.apache.org/sc"
>         xmlns:m="http://ofbiz.apache.org/m"
>         xmlns:s="http://ofbiz.apache.org/s"
>         xmlns:f="http://ofbiz.apache.org/f"
>         xmlns:sm="http://ofbiz.apache.org/sm"
>         xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/compound-widgets.xsd">
>     <site-conf>
>         <sc:request-map uri="CompoundWidgets1">
>             <sc:security https="true" auth="true"/>
>             <sc:event type="simple" invoke="CompoundWidgetsFunc" path="component://example/widget/example/ExampleCompoundWidgets.xml"/>
>             <sc:response name="success" type="view" value="CompoundWidgets1"/>
>         </sc:request-map>
>         <sc:request-map uri="CompoundWidgets2"><sc:security https="true" auth="true"/><sc:response name="success" type="view" value="CompoundWidgets2"/></sc:request-map>
>        
>         <sc:view-map name="CompoundWidgets1" type="screen" page="component://example/widget/example/ExampleCompoundWidgets.xml#CompoundWidgets1"/>
>         <sc:view-map name="CompoundWidgets2" type="screen" page="component://example/widget/example/ExampleCompoundWidgets.xml#CompoundWidgets2"/>
>     </site-conf>
> ...... the rest
> {code}
> 4. Change java code to support reading xml with namespace (i.e. xml for compound widgets)
> 5. Update the attributes at document level for rest of the controllers, menus, forms, simple methods and screens. Current setting will not work for schema with a namespace. For example, in controller.xml, we will change
> {code}
> xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/site-conf.xsd”
> {code}
> to
> {code}
> xmlns="http://ofbiz.apache.org/sc” xsi:schemaLocation="http://ofbiz.apache.org/dtds/site-conf-ns.xsd”>
> {code}

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)