[jira] [Commented] (OFBIZ-7078) Extend OrderAdjustment entity and add isManual field

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-7078) Extend OrderAdjustment entity and add isManual field

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-7078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15294762#comment-15294762 ]

Ashish Vijaywargiya commented on OFBIZ-7078:
--------------------------------------------

Hello Deepak,

Please commit this change in all the branches as well. The changes are really minor changes and I would say that this is missing functionality in those branches. So if you commit this changes over there then everyone will be fine IMO because you are adding code base that is taking care of missing/incomplete functionality.

> Extend OrderAdjustment entity and add isManual field
> ----------------------------------------------------
>
>                 Key: OFBIZ-7078
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-7078
>             Project: OFBiz
>          Issue Type: Improvement
>            Reporter: Deepak Dixit
>            Assignee: Deepak Dixit
>             Fix For: Upcoming Branch
>
>         Attachments: OFBIZ-7078.patch
>
>
> Extend OrderAdjustment entity and add isManual field to recognize manually added order adjustment.  
> As per current implementation code using orderAdjustment.comments field to recognize manually added comment using string "Added manually by"
> {code}
>                         if ( adjustment.get("comments") != null
>                                 && ((String)adjustment.get("comments")).startsWith("Added manually by")) {
>                             cart.addAdjustment(adjustment);
>                         }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)