[jira] [Commented] (OFBIZ-7112) EntityUtilProperties

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-7112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15686247#comment-15686247 ]

Pierre Smits commented on OFBIZ-7112:
-------------------------------------

Recapping the suggestion:
* when the key and value exist in the entity:SystemProperty, the value should be taken from the entity record
* when the key exist - but not the value - in the entity:SystemProperty, the value should be taken from the .properties file
* when the key and value don't exist in the entity:SystemProperty, the value should be taken from the .properties file.

I would say that the second point would make things more complicated (requiring code changes). If a key exists (in either entity:SystemProperty or .properties file) but it doesn't have a value, then a null is (or should be) returned. This might be a desired outcome.
And is already in place.

> EntityUtilProperties
> --------------------
>
>                 Key: OFBIZ-7112
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-7112
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: Trunk
>            Reporter: Wai
>            Assignee: Jacques Le Roux
>             Fix For: Upcoming Branch
>
>         Attachments: OFBIZ-7112.patch, OFBIZ-7112.patch, OFBIZ-7112.patch, OFBIZ-7112.patch
>
>
> Ofbiz reads properties from either a properties file or the entity:SystemProperty. The way it works previously is that ofbiz reads from the entity:SystemProperty first and if there is no value associated with the target propertyname, it would then locate the value from the relevant properties file.
> In other words, if there is a database entry for a property, the database entry should override the associated properties file.
> The issue is that if a database entry exist but the value is empty, it would look for a value from the properties file.  It should not do so.  If a database entry exists for the propertyname of interest, the value should be taken from the database even if it holds an empty value.

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)