[jira] [Commented] (OFBIZ-7113) Refactoring permission model call

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-7113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16617253#comment-16617253 ]

Jacques Le Roux commented on OFBIZ-7113:
----------------------------------------

Hi Nicolas,

I began to review, not yet done. Found few possible quirks which could need a patch update:

# Not sure why GeneralLedgerServices.xml is changed
# Same for applications/commonext/servicedef/services.xml
# Should it not be require-new-transaction and not required-new-transaction?
# ServiceErrorUiLabels.xml needs to be updated

I'll continue :)

> Refactoring permission model call
> ---------------------------------
>
>                 Key: OFBIZ-7113
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-7113
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Trunk
>            Reporter: Nicolas Malin
>            Assignee: Nicolas Malin
>            Priority: Minor
>         Attachments: OFBIZ-7113.patch, OFBIZ-7113.patch, OFBIZ-7113.patch
>
>
> With the subject on mailing list "Permission service not on the same transaction" : http://markmail.org/message/34vxi4ntmbj7vzcr
> I started the improvement but the java code need to be clean and refactoring.
> I share my first draft patch, but need more works. I realize :
>  * unified call evalPermission
>  * move all related field for permission service on ModelService to ModelPermission
>  * Remove  deprecated code
>  * start labelized error message  
>  * add new attributes on permission model : required-new-transaction and return-error-on-failure

--
This message was sent by Atlassian JIRA
(v7.6.3#76005)