[jira] [Commented] (OFBIZ-7143) Error on cancelling agreement

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-7143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15310061#comment-15310061 ]

Montalbano Florian commented on OFBIZ-7143:
-------------------------------------------

Hi,

The problem comes from the form "ListAgreements" when the service "getPartyNameForDate" is called.
The argument "partyId" is required for this service, however, its value can be null for an agreement since an agreement can be defined for a productId only. There is already some kind of workaround to avoid this problem but this does not seem to work.

I think that a possible solution to solve this problem is to either :
- rework the service, so it can accept a "_NA_" value from the input "partyId" (risk of allowing unexpected behavior)
- create a new service to keep the current constraint on the current service and redefine the behavior for the new service (duplication of code ++)
- move the behavior of "getPartyNameForDate" to a new service with every parameter as optional and make "getPartyNameForDate" call this new service with a constraint on the "partyId"

What do you think of these solutions ?

Have a nice day,
Florian

 

> Error on cancelling agreement
> -----------------------------
>
>                 Key: OFBIZ-7143
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-7143
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: Trunk
>            Reporter: Ravi Lodhi
>            Assignee: Ravi Lodhi
>            Priority: Minor
>
> Step to regenerate:
> 1) Go to Agreements screen under Accounting component.(https://localhost:8443/accounting/control/FindAgreement)
> 2) Cancel an agreement from the list.
> 3) See the error on Search Results section.

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)