[jira] [Commented] (OFBIZ-7147) Remove parentTypeId from InvoiceType data where InvoiceTypeId and parentTypeId are equal

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-7147) Remove parentTypeId from InvoiceType data where InvoiceTypeId and parentTypeId are equal

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-7147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15310878#comment-15310878 ]

Jacques Le Roux commented on OFBIZ-7147:
----------------------------------------

All the tests fail because of
bq. The following required parameter is missing: [IN] [getPartyAccountingPreferences.organizationPartyId]

How this is related with the proposed change is not obvious. Following testAcctgTransOnSalesInvoice (which fails) I though found this which is not quite clear to me
http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/data/AccountingTypeData.xml?r1=1000621&r2=1000620&pathrev=1000621
It's from http://svn.apache.org/viewvc?view=revision&revision=1000621
[~anilpatel] If you can remember, why and what to replace by "SALES"? Could it be related to the issue at hand?

> Remove parentTypeId from InvoiceType data where InvoiceTypeId and parentTypeId are equal
> ----------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-7147
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-7147
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: Release Branch 14.12, Trunk, Release Branch 15.12
>            Reporter: Arun Patidar
>            Assignee: Jacques Le Roux
>             Fix For: 14.12.01, Upcoming Branch, 15.12.01
>
>         Attachments: OFBIZ-7147.patch
>
>
> In InvoiceType data, we have invoiceTypeId value with same parentTypeId.
> Please refer AccountingTypeData.xml.
> <InvoiceType description="Purchase Invoice" hasTable="N" invoiceTypeId="PURCHASE_INVOICE"  parentTypeId="PURCHASE_INVOICE"/>
> <InvoiceType description="Sales Invoice" hasTable="N" invoiceTypeId="SALES_INVOICE" parentTypeId="SALES_INVOICE"/>
> Here, invoiceTypeId="PURCHASE_INVOICE"  has "PURCHASE_INVOICE" as its parentTypeId. Same applies for invoiceTypeId="SALES_INVOICE"
> This also causes issue of infinite loop with EntityTypeUtil.hasParentType() method.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)