[
https://issues.apache.org/jira/browse/OFBIZ-7180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15331588#comment-15331588 ]
Divesh Dutta commented on OFBIZ-7180:
-------------------------------------
I have tested this for sales order and purchase order both, and its working fine. One minor improvement in patch is that you have added new condition for price change option:
{code}
!(orderItem.statusId == "ITEM_CANCELLED" || orderItem.statusId == "ITEM_COMPLETED")
{code}
we can use itemStatusOkay flag available in same file for this condition. Rest all looks good. Once you make these change, I can commit the code.
> Completed Service Order Items are being allowed to be edited over Approved PO
> ------------------------------------------------------------------------------
>
> Key: OFBIZ-7180
> URL:
https://issues.apache.org/jira/browse/OFBIZ-7180> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: Release Branch 14.12
> Reporter: Swapnil Shah
> Assignee: Divesh Dutta
> Priority: Critical
> Attachments: OFBIZ-7180.patch, SV_1.png, SV_2.png, SV_3.png
>
>
> Currently PO line items having service type products are completed on Approval itself. But system still allows the Completed service items to be edited over any Approved PO (e.g. if PO has both service and finished good items that still need to be received). This lead to difference in invoice and order valuation.
> We could possibly restrict the editing for any completed order items via Edit Items option over Order view.
> Please refer to attached screenshot for reference
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Locked
