[jira] [Commented] (OFBIZ-7180) Completed Service Order Items are being allowed to be edited over Approved PO

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-7180) Completed Service Order Items are being allowed to be edited over Approved PO

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-7180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15331605#comment-15331605 ]

Divesh Dutta commented on OFBIZ-7180:
-------------------------------------

Okay, I looked more at code and it seems that we cannot use itemStatusOkay as value of this flag is dependent on values of orderItemShipGroupAssoc record which is inside the iterator. And itemStatusOkay is not available when we are checking condition for price change. So patch looks good to me.  

> Completed Service Order Items are being allowed to be edited over Approved PO
> ------------------------------------------------------------------------------
>
>                 Key: OFBIZ-7180
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-7180
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>            Reporter: Swapnil Shah
>            Assignee: Divesh Dutta
>            Priority: Critical
>         Attachments: OFBIZ-7180.patch, SV_1.png, SV_2.png, SV_3.png
>
>
> Currently PO line items having service type products are completed on Approval itself. But system still allows the Completed service items to be edited over any Approved PO (e.g. if PO has both service and finished good items that still need to be received). This lead to difference in invoice and order valuation.
> We could possibly restrict the editing for any completed order items via Edit Items option over Order view.
> Please refer to attached screenshot for reference



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)