[jira] [Commented] (OFBIZ-7184) 'Data Source Id' should be editable/visible on error view screen of createDataSource

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-7184) 'Data Source Id' should be editable/visible on error view screen of createDataSource

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-7184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15318099#comment-15318099 ]

Montalbano Florian commented on OFBIZ-7184:
-------------------------------------------

The form to look at is DataSourceForms.xml#EditDataSource.
In this form, we look for the value of the dataSource and the dataSourceId. When the form is submitted without a dataSourceId, the controller send the same form with an error and in the form, the following condition is triggered :
{code}<field use-when="dataSource==null&amp;&amp;dataSourceId!=null" name="dataSourceId" title="${uiLabelMap.DataSourceDataSourceId}" tooltip="${uiLabelMap.CommonCannotBeFound}: [${dataSourceId}]"><display/></field>{code}

DataSource is null (else, the first field would show something else).
So, the dataSourceId is somehow not considered "null". I think it may be because the createDataSource service return a empty String when there is an error. I tried to display the value of dataSourceId in a field but nothing shows up...

The condition that we need to hit is the following :
{code}<field use-when="dataSource==null&amp;&amp;dataSourceId==null" name="dataSourceId" title="${uiLabelMap.DataSourceDataSourceId}"><text/></field>{code}

So either we change this condition, either we send a dataSourceId with a null value.

Do you have any idea about this ?


> 'Data Source Id' should be editable/visible on error view screen of createDataSource
> ------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-7184
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-7184
>             Project: OFBiz
>          Issue Type: Bug
>          Components: marketing
>    Affects Versions: Trunk
>            Reporter: Chandan Khandelwal
>            Assignee: Vaibhav Jain
>         Attachments: screenshot-1.png
>
>
> Steps to regenerate the issue-
> # Go to https://localhost:8443/marketing/control/main
> # Click on sub-menu DataSource
> # Click on create data source
> # Click "Save" without filling input fields
> # Instead of input field, label is shown Could not be found: []
> (Please refer screenshot for more details)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)