[jira] [Commented] (OFBIZ-7184) 'Data Source Id' should be editable/visible on error view screen of createDataSource

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-7184) 'Data Source Id' should be editable/visible on error view screen of createDataSource

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-7184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15318287#comment-15318287 ]

Pranay Pandey commented on OFBIZ-7184:
--------------------------------------

Hi Montalbano,

Thanks for posting your research on this issue.
The place you are looking at the problem is correct, but actually the reason is not service OUT  attribtue. The problem is same form is used for Create and Update operation and hence the setup has been trying to support both the cases and now confusing the user experience.

I checked the service definition, dataSourceId is not out parameter from createDataSource or updateDataSource

I think putting dataSourceId field this way can help:
{code}
<field use-when="dataSource!=null" name="dataSourceId" title="${uiLabelMap.DataSourceDataSourceId}"><display/></field>
 <field use-when="dataSource==null" name="dataSourceId" title="${uiLabelMap.DataSourceDataSourceId}" required-field="true"><text/></field>
{code}

Becuase if dataSourceId is found in parameters and if it's valid anyways we are going to get the dataSource record from screen defiintion.

Let's see what are the other thoughts from the community.



> 'Data Source Id' should be editable/visible on error view screen of createDataSource
> ------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-7184
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-7184
>             Project: OFBiz
>          Issue Type: Bug
>          Components: marketing
>    Affects Versions: Trunk
>            Reporter: Chandan Khandelwal
>            Assignee: Vaibhav Jain
>         Attachments: screenshot-1.png
>
>
> Steps to regenerate the issue-
> # Go to https://localhost:8443/marketing/control/main
> # Click on sub-menu DataSource
> # Click on create data source
> # Click "Save" without filling input fields
> # Instead of input field, label is shown Could not be found: []
> (Please refer screenshot for more details)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)