[
https://issues.apache.org/jira/browse/OFBIZ-7272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15380557#comment-15380557 ]
Rishi Solanki commented on OFBIZ-7272:
--------------------------------------
Few more classes needs to be taken care or discuss;
{code}
framework/entity/src/org/ofbiz/entity/transaction/TransactionUtil.java
framework/service/src/org/ofbiz/service/ServiceUtil.java
framework/service/src/org/ofbiz/service/calendar/TemporalExpressionWorker.java
DataResourceWorker.java
ProductUtil.java
CategoryUtil.java
StartupCommandUtil.java
ICalWorker.java
JNDIConfigUtil.java
{code}
> Enforce noninstantiability to all Utility classes
> -------------------------------------------------
>
> Key: OFBIZ-7272
> URL:
https://issues.apache.org/jira/browse/OFBIZ-7272> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
> Affects Versions: Trunk
> Reporter: Rishi Solanki
> Assignee: Arun Patidar
> Attachments: OFBIZ-7272.patch
>
>
> I have discusses this in past on mailing list, that Utility, helper, worker classes which contains only static methods should not be instantiable. Also we can restrict it by adding a private constructor.
> Currently OFBiz has many such classes which should have private constructor. Identify all the *Worker.java, *.Helper.java, and *Util.java which do not have any non static method/member are eligible for having a private constructor.
> Reference why we should do this :
http://www.informit.com/articles/article.aspx?p=1216151&seqNum=4--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Locked
