[
https://issues.apache.org/jira/browse/OFBIZ-7311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15338080#comment-15338080 ]
Pranay Pandey commented on OFBIZ-7311:
--------------------------------------
Thanks Wai for reviewing the commit and posting your finding. Yes I completely agree with you. As with these patches all themes were tested and found working fine I closed this ticket. Reopening it now, to remove the remaining references to maincss.css and mainrtl.css. As of now there are total 50 occurrences found for maincss.css and 1 occurrence found for mainrtl.css.
> Formatting and renaming of the CSS files as per best practices
> --------------------------------------------------------------
>
> Key: OFBIZ-7311
> URL:
https://issues.apache.org/jira/browse/OFBIZ-7311> Project: OFBiz
> Issue Type: Improvement
> Components: themes
> Affects Versions: Trunk
> Reporter: Swapnil M Mane
> Assignee: Pranay Pandey
> Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7311-bizznesstime.patch, OFBIZ-7311-bluelight.patch, OFBIZ-7311-droppingcrumbs.patch, OFBIZ-7311-flatgrey.patch, OFBIZ-7311-multiflex.patch, OFBIZ-7311-rainbowstone.patch, OFBIZ-7311-renamed-maincss-to-style.patch, OFBIZ-7311-tomahawk.patch
>
>
> In CSS files, we are having various inconsistency in the formatting of the code for e.g. we have following types of code formatting
> // No space
> {code}
> ul#preferences-menu a:hover {
> text-decoration: none;
> }
> {code}
> // Space of 2
> {code}
> div.autocomplete ul {
> list-style-type:none;
> margin:0;
> padding:0;
> }
> {code}
> // Space of 4
> {code}
> .control-area a {
> font-size: 1.1em;
> color: #5CA3D7;
> }
> {code}
> For better readability we should format the existing files with space of 4.
> Also for some theme, we named CSS files as *maincss.css* and for some, we named it as *style.css*. We can rename these file as per best practices for consistency.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Locked
