[jira] [Commented] (OFBIZ-7311) Formatting and renaming of the CSS files as per best practices

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-7311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15443388#comment-15443388 ]

Swapnil M Mane commented on OFBIZ-7311:
---------------------------------------

Dear [~wt],

It seems you have missed the recent patch uploaded on 15/Jul/16 15:36, *OFBIZ-7311-removed_references_of_maincss.patch*

https://issues.apache.org/jira/secure/attachment/12818181/OFBIZ-7311-removed_references_of_maincss.patch

Please let me know, if I am still missing something.

Thanks for your inputs.

Swapnil M Mane

> Formatting and renaming of the CSS files as per best practices
> --------------------------------------------------------------
>
>                 Key: OFBIZ-7311
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-7311
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: themes
>    Affects Versions: Trunk
>            Reporter: Swapnil M Mane
>            Assignee: Pranay Pandey
>            Priority: Minor
>             Fix For: Upcoming Branch
>
>         Attachments: OFBIZ-7311-bizznesstime.patch, OFBIZ-7311-bluelight.patch, OFBIZ-7311-droppingcrumbs.patch, OFBIZ-7311-flatgrey.patch, OFBIZ-7311-multiflex.patch, OFBIZ-7311-rainbowstone.patch, OFBIZ-7311-removed_references_of_maincss.patch, OFBIZ-7311-renamed-maincss-to-style.patch, OFBIZ-7311-tomahawk.patch
>
>
> In CSS files, we are having various inconsistency in the formatting of the code for e.g. we have following types of code formatting
> // No space
> {code}
> ul#preferences-menu a:hover {
> text-decoration: none;
> }
> {code}
> // Space of 2
> {code}
> div.autocomplete ul {
>   list-style-type:none;
>   margin:0;
>   padding:0;
> }
> {code}
> // Space of 4
> {code}
> .control-area a {
>     font-size: 1.1em;
>     color: #5CA3D7;
> }
> {code}
> For better readability we should format the existing files with space of 4.
> Also for some theme, we named CSS files as *maincss.css* and for some, we named it as *style.css*. We can rename these file as per best practices for consistency.

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)