[jira] [Commented] (OFBIZ-7339) Replace EntityUtilProperties getPropertyValue method with correct method calls

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-7339) Replace EntityUtilProperties getPropertyValue method with correct method calls

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15334050#comment-15334050 ]

Rishi Solanki commented on OFBIZ-7339:
--------------------------------------

Thanks for heads up Jacques, reviewed the work committed and nothing to worry about it as we are using different methods and no signature changed in Wai's work. Also after taking update from trunk, I've tested the work given here by [~rahul.kushwah] is working fine.

So these changes have no impact from OFBIZ-7122. And it covers how to use OFBIZ api, so we are good. Thanks!

> Replace EntityUtilProperties getPropertyValue method with correct method calls
> ------------------------------------------------------------------------------
>
>                 Key: OFBIZ-7339
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-7339
>             Project: OFBiz
>          Issue Type: Bug
>          Components: content, framework, manufacturing, party, product, securityext, specialpurpose/ecommerce, specialpurpose/lucene, specialpurpose/passport, workeffort
>    Affects Versions: Trunk
>            Reporter: Rishi Solanki
>            Assignee: Arun Patidar
>         Attachments: EntityUtilProperties.patch
>
>
> In current OFBiz system at many places many methods implemented but not used as per their purpose. One example is in EntityUtilProperties we have getPropertyAsInteger() and getPropertyAsBigDecimal() and other methods which returns specific type data. But at most places system uses getPropertyValue() which returns string and then do explicit conversions.
> System should use proper methods for which they have been implemented.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)