[jira] [Commented] (OFBIZ-7362) Add paginate target to list forms to fix the pagination error

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-7362) Add paginate target to list forms to fix the pagination error

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-7362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15335647#comment-15335647 ]

Amardeep Singh Jhajj commented on OFBIZ-7362:
---------------------------------------------

Yes, the error was same as you mentioned. But reason of issue is not exactly the same. In OFBIZ-2330, error comes when we call any service from request and parameters passed in URL instead of using form. But, in this issue, the URL was incorrect for paginations. It should be

{code}
https://localhost:8443/content/control/ContentSetupMenu?VIEW_SIZE_1=20&VIEW_INDEX_1=1
{code}

instead of

{code}
https://localhost:8443/content/control/updateContentType?parentTypeId=PLACEHOLDER&hasTable=Y&foo=UpdateContentType_o_0&contentTypeId=DEPARTMENT&description=Department&VIEW_SIZE_1=20&VIEW_INDEX_1=1
{code}

Currently, If URL is not given in paginate-target then pagination URL will be page URL. So URL should be given in paginate-target.

We have lot of list forms in OFBiz without paginate-target which can cause the above issue. So this ticket is itself a parent ticket and further child tickets will be added in it for various components.

> Add paginate target to list forms to fix the pagination error
> -------------------------------------------------------------
>
>                 Key: OFBIZ-7362
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-7362
>             Project: OFBiz
>          Issue Type: Bug
>          Components: content
>    Affects Versions: Trunk
>            Reporter: Amardeep Singh Jhajj
>            Assignee: Amardeep Singh Jhajj
>
> I found issue in pagination on some screens when we do any operation (like update, delete) on list item.
> For example: I have updated the content type from list in Content Setup Menu in Content application and then clicked on next link of pagination, I got the following error:
> {code}
> The Following Errors Occurred:
> Error calling event: org.ofbiz.webapp.event.EventHandlerException: Found URL parameter [contentTypeId] passed to secure (https) request-map with uri [updateContentType] with an event that calls service [updateContentType]; this is not allowed for security reasons!
> {code}
> The above error is unexpected as I just tried to see next list records of ContentType. The reason of error is pagination URL which is same as URL of page i.e. updateContentType. This URL is the update operation URL and it is not redirected to appropriate page after operation.
> Pagination target URL should be independent of page URL and it should be added on form using paginate-target attribute of form widget.
> This is a parent ticket and child tickets will be added in it for components.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)