[jira] [Commented] (OFBIZ-7378) InvoiceWorker.java

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-7378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15337531#comment-15337531 ]

Rishi Solanki commented on OFBIZ-7378:
--------------------------------------

Thanks to [~arun.patidar] for discussion and finalize what to do with this class.

> InvoiceWorker.java
> ------------------
>
>                 Key: OFBIZ-7378
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-7378
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>    Affects Versions: Trunk
>            Reporter: Rishi Solanki
>            Priority: Minor
>
> - Make InvoiceWorker class as final.
> - Add a private constructor.
> - Make the following private static variable as final.
> {code}
>     private static BigDecimal ZERO = BigDecimal.ZERO;
>     private static int decimals = UtilNumber.getBigDecimalScale("invoice.decimals");
>     private static int rounding = UtilNumber.getBigDecimalRoundingMode("invoice.rounding");
>     private static int taxDecimals = UtilNumber.getBigDecimalScale("salestax.calc.decimals");
>     private static int taxRounding = UtilNumber.getBigDecimalRoundingMode("salestax.rounding");
> {code}

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)