[
https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15355281#comment-15355281 ]
Pierre Smits commented on OFBIZ-7534:
-------------------------------------
Having applied the latest patch (
https://issues.apache.org/jira/secure/attachment/12814684/OFBIZ-7534.patch) to a new check-out of OFBiz trunk, I had the chance to do a review of the various changes implemented.
Here are (some of) my findings
* though the intended gradle functions are intended to replace ant, ant functions still exist in the modified check-out.
* the readme was deleted and a new readme.md was introduced - this seems to be beyond the goal of the issue. Changes could have been implemented in the original readme.
* With respect to the new readme.md:
** it states: 'make sure of running the appropriate eclipse command which is mentioned in this file'. Yet where to find it in the long file is forgotten. Including that will increase the UX of OFBiz with respect to the dev part of devops.
** it stated '`./gradlew cleanAll loadDefault` as the command to execute a preparation phase on unix like machines (like my MacBook Pro). On activating/executing that command in the directory of the new checkout I get:
{code}
-bash: ./gradlew: Permission denied
{code} so somehow my permissions got changed with the implementation of the patch. This is unacceptable without proper explanation. And even with such it is highly questionable.
So that stopped me from going further in that aspect.
Looking at the patch file itself I see a lot of references to the external (3rd party) jar files removed from the .classpath file, as per addressing the resolution by the PMC of not having jar files in the repo's of the project anymore.
Though I applied the whole patch to the check-out, none of the jar files were removed.
Re: './gradlew ofbiz' - as explained in the readme.md file.
This is a confusing command/task, as it semantically means nothing. Mutltiple other commands/tasks (e.g. ./gradlew cleanAll) have a meaning in itself. This hasn't.
More will follow.
> Migrate OFBiz from Apache Ant to Gradle build system
> ----------------------------------------------------
>
> Key: OFBIZ-7534
> URL:
https://issues.apache.org/jira/browse/OFBIZ-7534> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
> Affects Versions: Upcoming Branch
> Reporter: Taher Alkhateeb
> Assignee: Taher Alkhateeb
> Labels: ant, build-tools, gradle
> Attachments: ANT_GRADLE_COMPARISON.txt, OFBIZ-7534.patch, OFBIZ-7534.patch, OFBIZ-7534.patch, build.gradle, gradle-wrapper.jar
>
>
> This is a major refactoring task referring to the [email thread|
http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle] in which the community voted for the switch after a proposal from the PMC
> The purpose of this JIRA is to achieve the following objectives
> - Fully implement a working compiling system in Gradle that passes all tests
> - Remove all ant and maven build scripts from the system
> - update the documentation of the system to reflect these changes
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Locked
