[jira] [Commented] (OFBIZ-7598) Empty header row should not render if list to render in file is empty

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16590157#comment-16590157 ]

Gil Portenseigne commented on OFBIZ-7598:
-----------------------------------------

Reading your patch, why using {{Boolean}} and not {{boolean}} ?

Apart from that i think it's ok to commit it !  
I wonder if it's not better to revert then commit the whole feature in one hit, for history sake. Not a big deal in my opinion :)

> Empty header row should not render if list to render in file is empty
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-7598
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-7598
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Trunk
>            Reporter: Suraj Khurana
>            Assignee: Suraj Khurana
>            Priority: Major
>             Fix For: Upcoming Branch
>
>         Attachments: Image 002.png, OFBIZ-7598.patch, OFBIZ-7598.patch, OFBIZ-7598.patch, OFBIZ-7598.patch, OFBIZ-7598.patch, OFBIZ-7598.png, OFBIZ-7598_improvement.patch, OFBIZ-7598_improvement.patch
>
>
> If list inside form doesn't contain data, then header row should not render from better UI perspective and proper message should be shown to user.
> Please refer screenshot for details.

--
This message was sent by Atlassian JIRA
(v7.6.3#76005)