[
https://issues.apache.org/jira/browse/OFBIZ-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15372913#comment-15372913 ]
Rishi Solanki commented on OFBIZ-7622:
--------------------------------------
[~julien.nicolas]: Sorry I still disagree on this, to manage fields creation and its relationship in this way. In case we found more entities which requires the same field then we will be altering the final static map probably (defined to manage the list of entities manage this extra field). I think its better to have the entities fields with them, instead of create them from any configuration.
Also we are increasing responsibilities of EntityAutoEngine or GenericDAO or ModelEntity. It could be out of scope but we should consider this before assigning more responsibilities to same class.
I'm good, if we found some good reason to make it configurable. As I see for few entities change by user login is must from business perspective and for few it may be optional. So enabling/disabling all from one configuration seems okay to me, and managing it at entity level seems better.
Thanks!
> Add "changeByUserLoginId" field for CustRequestStatus
> -----------------------------------------------------
>
> Key: OFBIZ-7622
> URL:
https://issues.apache.org/jira/browse/OFBIZ-7622> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL COMPONENTS
> Affects Versions: Trunk
> Reporter: Nameet Jain
> Assignee: Julien NICOLAS
> Attachments: OFBIZ-7622.patch, OFBIZ-7622.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Locked
