[jira] [Commented] (OFBIZ-7623) Add "changeByUserLoginId" field for FinAccountStatus

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-7623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15372610#comment-15372610 ]

Jacques Le Roux commented on OFBIZ-7623:
----------------------------------------

I read in the commit comment
bq. Today only alphabetic variable with '_' are detected (i.e. my_variable==null).
and in commit this snippet
{code}
+            if (UtilValidate.isNotEmpty(expression)) {
+                //analyse expression to find variables by split non alpha, ignoring "_" to allow my_variable usage
+                String [] variables = expression.split("[\\P{Alpha}&&[^_]]+");
+                for (String variable: variables)
+                    if(!vars.containsKey(variable)) vars.put(variable, null);
+            }
{code}

Should we not make this clearer somewhere (not sure how, just asking at this point)?

> Add "changeByUserLoginId" field for FinAccountStatus
> ----------------------------------------------------
>
>                 Key: OFBIZ-7623
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-7623
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL COMPONENTS
>    Affects Versions: Trunk
>            Reporter: Nameet Jain
>            Assignee: Nicolas Malin
>             Fix For: Upcoming Branch
>
>         Attachments: OFBIZ-7623.patch, OFBIZ-7623.patch
>
>

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)