[jira] [Commented] (OFBIZ-7657) Use 'conditionFields' in LookupContact

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-7657) Use 'conditionFields' in LookupContact

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-7657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352671#comment-15352671 ]

Montalbano Florian commented on OFBIZ-7657:
-------------------------------------------

Hi [~deepakddixit],
you are right, both are doing the same thing. I asked in OFBIZ-7576 if there was a difference and [~jacques.le.roux] said it was just epsilon difference in performance but easier to read. That's why, I'm changing the 'andCondition' to 'conditionFields'.

I read your other comment and if there is no need to declare the 'conditionFields' as a map then it's even better !

Is that ok for you ?

> Use 'conditionFields' in LookupContact
> --------------------------------------
>
>                 Key: OFBIZ-7657
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-7657
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: party
>    Affects Versions: Trunk
>            Reporter: Montalbano Florian
>            Priority: Minor
>              Labels: andCondition, autocomplete, conditionFields, lookup
>         Attachments: OFBIZ-7657.patch
>
>
> Change 'andCondition' (which uses direct groovy call) to 'conditionFields' in the lookup LookupScreens#LookupContact.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)