[jira] [Commented] (OFBIZ-7684) Enforce noninstantiability to ServiceConfigUtil class

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-7684) Enforce noninstantiability to ServiceConfigUtil class

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-7684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15360048#comment-15360048 ]

Rahul Singh commented on OFBIZ-7684:
------------------------------------

Added the patch to fix this issue. Thanks, [~rishisolankii] for the detailed description.

> Enforce noninstantiability to ServiceConfigUtil class
> -----------------------------------------------------
>
>                 Key: OFBIZ-7684
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-7684
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: framework
>    Affects Versions: Trunk
>            Reporter: Rishi Solanki
>            Priority: Minor
>         Attachments: OFBIZ-7684.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make the following public static variables as private
> {code}
>     public static final String engine = "default";
>     public static final String SERVICE_ENGINE_XML_FILENAME = "serviceengine.xml";
> {code}
> - Add public static method as getServiceEngineXmlFileName(), getEngine() and use them in following class
> {code}
>     ServiceEcaUtil.java
>     ServiceGroupReader.java
>     DispatchContext.java
>     JobPoller.java
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)