[jira] [Commented] (OFBIZ-7763) Replace bshInterpreter with groovyShell

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-7763) Replace bshInterpreter with groovyShell

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-7763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15374400#comment-15374400 ]

Jacques Le Roux commented on OFBIZ-7763:
----------------------------------------

I finally don't think we need to say more about that to users. Variables names should simply follow Java syntax (I just learnt that $ is an acceptable character in a Java variable name but is not recommended, at least to start with http://www.oracle.com/technetwork/java/codeconventions-135099.html#367).

To follow Java syntax, where variables names can contain but not start by numbers, I'd simply replace Alpha by Alnum in the regexp. Of course, variables names starting by a number and isolated numbers should be removed from the variables names list. I see no other issues introduced by replacing Alpha by Alnum, but better to think twice ;)


> Replace bshInterpreter with groovyShell
> ---------------------------------------
>
>                 Key: OFBIZ-7763
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-7763
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Trunk
>            Reporter: Gil Portenseigne
>            Assignee: Gil Portenseigne
>             Fix For: Upcoming Branch
>
>         Attachments: OFBIZ-7763.patch, beanshell-removal-part1.patch
>
>
> To support the migration to gradle, removing bsh.jar dependency from the project, and improve readability and fonctionnalities following [~deepak.dixit] idea expressed here https://issues.apache.org/jira/browse/OFBIZ-7576?focusedCommentId=15347972



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)