[jira] [Commented] (OFBIZ-7771) Rename loadDefault to something less ambiguous

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-7771) Rename loadDefault to something less ambiguous

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-7771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15369479#comment-15369479 ]

Taher Alkhateeb commented on OFBIZ-7771:
----------------------------------------

LoadDefault loads the default data as decided by the OFBiz server, which was working this way for many years! All that I did was change load-demo to loadDefault. load-demo is more confusing because it means load the demo data for a demo system which is not true. load-demo is used for multiple other purposes. Now, ofbiz by default loads certain data, hence the name loadDefault, it's the default by the server ... This is the most correct version.

Now it happens that the server default data is seed, seed-initial and demo. However, this is done inside the code of the server, not the build system, and again, this was the case for many, many years. So all that we are doing is calling a spade a spade!

With that being said, we can put a comment in the README.md file to explain what the default data is.

> Rename loadDefault to something less ambiguous
> ----------------------------------------------
>
>                 Key: OFBIZ-7771
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-7771
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: framework
>    Affects Versions: Trunk
>            Reporter: Pierre Smits
>            Priority: Minor
>
> The gradle task loadDefault is ambiguous, as it means different things to different uses. This could lead to a situations where it is used in a wrong manner, resulting in data being overwritten.
> Having a more meaningful name lessens the risk of such situations.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)