[jira] [Commented] (OFBIZ-7783) External library files are not in the OFBiz folder structure.

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-7783) External library files are not in the OFBiz folder structure.

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-7783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15434632#comment-15434632 ]

Jacques Le Roux commented on OFBIZ-7783:
----------------------------------------

Hi Taher,

Quoting your point 1
bq. so what is wrong with having other libs or eclipse in your dev machine? I don't see where the problem is?
Actually there are 3 different issues:
# OWASP dependency check
# The issue Pierre expressed here
# Delivering binary releases

# is addressed at OFBIZ-7930, one less
# I let Pierre answer
# is new, as I explained in a comment above, and need to be discussed on a separate dev ML thread. It's not mandatory to provide binary releases to users but I believe it would be a good thing. Even TLP projects which are using Maven do so. For that we could follow the way eg jMeter, Ant or Tomcat organises their libs in their binaries. Hence the need to extract and dispatch. Tomcat way seems the easiest, only 1 lib folder with all jars.

bq. I also don't understand why we would need to download the libraries for binary releases. What is wrong with Gradle downloading whatever you need?
As their name say it, binary releases contain the binaries, hence all the jars necessary for the project to work OOTB w/o using Gradle. This of course would need to specify the jars location as a repository, that can be documented. As I said it's not mandatory, and the project could decide to not do it since Gradle provides them. But we should consider existing examples among important TLP projects as above before taking this decision. This could help to answer Pierre's need. Only Pierre expressed this need so far, but I see no reasons why it would be the only one not able to use our OOTB Gradle settings (ie jcenter repo). Again, we don't need to do it, *just document it*!

> External library files are not in the OFBiz folder structure.
> -------------------------------------------------------------
>
>                 Key: OFBIZ-7783
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-7783
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL COMPONENTS
>            Reporter: Pierre Smits
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: Upcoming Branch
>
>
> With the implementation of the external library download feature of gradle/gradlew, the external libraries (jar files) are not in the folder structure any more.
> They should reside there, like before.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)