[jira] [Commented] (OFBIZ-7812) Enforce noninstantiability to DatabaseUtil class

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-7812) Enforce noninstantiability to DatabaseUtil class

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-7812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15380546#comment-15380546 ]

Rishi Solanki commented on OFBIZ-7812:
--------------------------------------

DataBaseUtil class by name looks like a utility class which contains the static method. But by implementation it is not a class which can not be instantiated. So this class won't come under this effort. We can close this ticket. Thanks to [~arunpati] and [~rohit.koushal], [~rahul.kushwah] for discussion and finalizing.

> Enforce noninstantiability to DatabaseUtil class
> ------------------------------------------------
>
>                 Key: OFBIZ-7812
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-7812
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: framework
>            Reporter: Arun Patidar
>            Priority: Minor
>
> - Make class as final.
> - Add a private constructor.
> - Make following protected variable as private
> {code}
>       protected ModelFieldTypeReader modelFieldTypeReader = null;
>     protected Datasource datasourceInfo = null;
>     protected GenericHelperInfo helperInfo = null;
>     // Legacy Connections
>     protected String connectionUrl = null;
>     protected String driverName = null;
>     protected String userName = null;
>     protected String password = null;
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)