[jira] [Commented] (OFBIZ-7893) Rename generated *ofbiz-gradle.jar* to *ofbiz.jar*

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-7893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15398171#comment-15398171 ]

Jacques Le Roux commented on OFBIZ-7893:
----------------------------------------

Pierre your second patch is deprecated (better to keep the same name, Jira then grays the older ones, easier to pick the last one, this in contributor best practices)
# I have already updated rc.ofbiz and rc.ofbiz.for.debian
# OFBIZ-7930 proposes a more advanced copyExternalJars task than copyToLib (with now locally its counterpart cleanExternalJars which I have problems with - I'll explain later)
# What developmentGroup is intended for?

So I could agree about (but moot point)
{code}
 +def jvmArguments = ['-Xms528M', '-Xmx1024M']
{code}
and maybe
{code}
+    archiveName = "ofbiz.jar"
+    destinationDir = file("$rootDir")
+    exclude ('*.xml')
+    exclude ('*.txt')
+    exclude ('*.jks')
+    exclude ('README'
{code}
but I think it's incomplete

Thanks for your work!

> Rename generated *ofbiz-gradle.jar* to *ofbiz.jar*
> --------------------------------------------------
>
>                 Key: OFBIZ-7893
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-7893
>             Project: OFBiz
>          Issue Type: Sub-task
>            Reporter: Pierre Smits
>            Assignee: Pierre Smits
>         Attachments: OFBIZ-7893-build.gradle-v2.patch, OFBIZ-7893-build.gradle.patch
>
>
> With the implementation of the Gradle build methodology the name of the OFBiz executable changed from *ofbiz.jar* to *ofbiz-gradle.jar*.
> In order to keep consistency with older releases this should be changed so that the old name is back.

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)