[jira] [Commented] (OFBIZ-8056) Maximise the utilisation of the Label CommonProduct in various accounting forms

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-8056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15501077#comment-15501077 ]

Michael Brohl commented on OFBIZ-8056:
--------------------------------------

Had a deeper look and now I think the patch is wrong!
It mixes up Product and Product Id uses and translates them all to CommonProduct.

{code:xml}
-                        <fo:block font-weight="bold">${uiLabelMap.AccountingProduct}</fo:block>
+                        <fo:block font-weight="bold">${uiLabelMap.CommonProduct}</fo:block>
                       </fo:table-cell>
                       <fo:table-cell border-bottom-style="solid" border-bottom-width="thin" border-bottom-color="black">
                         <fo:block font-weight="bold">${uiLabelMap.CommonDescription}</fo:block>
Index: applications/accounting/template/reports/AcctgTransEntriesSearchResult.fo.ftl
===================================================================
--- applications/accounting/template/reports/AcctgTransEntriesSearchResult.fo.ftl (revision 1758118)
+++ applications/accounting/template/reports/AcctgTransEntriesSearchResult.fo.ftl (working copy)
@@ -85,7 +85,7 @@
                                     <fo:block text-align="center" font-size="6pt">${uiLabelMap.CommonPartyId}</fo:block>
                                 </fo:table-cell>
                                 <fo:table-cell border="1pt solid" border-width=".1mm">
-                                    <fo:block text-align="center" font-size="6pt">${uiLabelMap.AccountingProductId}</fo:block>
+                                    <fo:block text-align="center" font-size="6pt">${uiLabelMap.CommonProduct}</fo:block>
{code}

> Maximise the utilisation of the Label CommonProduct in various accounting forms
> -------------------------------------------------------------------------------
>
>                 Key: OFBIZ-8056
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-8056
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>    Affects Versions: Trunk
>            Reporter: Pierre Smits
>            Priority: Minor
>              Labels: labels
>         Attachments: OFBIZ-8056-accounting-CommonProduct.patch
>
>
> There are many forms in the accounting component referencing the product. This issue is about applying the CommonProduct label where it is possible.

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)