[
https://issues.apache.org/jira/browse/OFBIZ-8153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16134435#comment-16134435 ]
Jacques Le Roux commented on OFBIZ-8153:
----------------------------------------
Thanks Suraj,
Your pach looks good to me. I tested you get indeed less unused labels (2184 vs 2201). I wondered why in 3 places we use uiLabelMap.get("xxxxx") instead of uiLabelMap.xxxxx which [does essentially the same when there is no default parameter passed to get()|
http://mrhaki.blogspot.fr/2009/11/groovy-goodness-get-value-from-map-or.html]. So I changed them at r1805548. But anyway we can hardly prevent committers to use uiLabelMap.get("xxxxx") so I kept it in your patch.
BTW I'm not quite sure I understood these sentences
bq. Tried for uiLabelMap.AccountingTotalAssets in BalanceSheet.groovy in the accounting component, didn't get any luck.
bq. Should not be like uiLabelMap.xxxxx( (As it might be calling a method of ResourceBundleMapWrapper class)
For the second I guess it was about existing code in LabelReferences.java
Anyway your patch is in
trunk r1805558
R16.11 r1805559
R15.12, R14.12, R13.07 r1805560
> LabelManager doesn't search labels in .groovy files
> ---------------------------------------------------
>
> Key: OFBIZ-8153
> URL:
https://issues.apache.org/jira/browse/OFBIZ-8153> Project: OFBiz
> Issue Type: Bug
> Components: framework/webtools
> Affects Versions: Release Branch 14.12, Trunk, Release Branch 15.12
> Reporter: Pierre Smits
> Assignee: Suraj Khurana
> Fix For: Release Branch 13.07, Release Branch 14.12, 16.11.01, Release Branch 15.12
>
> Attachments: OFBIZ-8153.patch
>
>
> There are over 60 labels used in groovy files. These don't get reflected in the counts of the label manager and in the search for labels not used.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
Locked
