[jira] [Commented] (OFBIZ-8153) LabelManager doesn't search labels in .groovy files

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-8153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16134735#comment-16134735 ]

Suraj Khurana commented on OFBIZ-8153:
--------------------------------------

Thanks [~jacques.le.roux],
{quote}Tried for uiLabelMap.AccountingTotalAssets in BalanceSheet.groovy in the accounting component, didn't get any luck.{quote}

I tried to test this considering uiLabelMap.AccountingTotalAssets in BalanceSheet.groovy but it was not working earlier.

{quote}Should not be like uiLabelMap.xxxxx( (As it might be calling a method of ResourceBundleMapWrapper class){quote}

There are some occurrences such as uiLabelMap.addBottomResourceBundle("CommonUiLabels") as well, which are not in our scope of consideration.

I am also thinking some way by which existing code in LabelReferences.java can be handled/ignored to improve performance. :)

> LabelManager doesn't search labels in .groovy files
> ---------------------------------------------------
>
>                 Key: OFBIZ-8153
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-8153
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework/webtools
>    Affects Versions: Release Branch 14.12, Trunk, Release Branch 15.12
>            Reporter: Pierre Smits
>            Assignee: Jacques Le Roux
>             Fix For: Release Branch 13.07, Release Branch 14.12, Release Branch 15.12, 16.11.04
>
>         Attachments: OFBIZ-8153.patch
>
>
> There are over 60 labels used in groovy files. These don't get reflected in the counts of the label manager and in the search for labels not used.

--
This message was sent by Atlassian JIRA
(v6.4.14#64029)