[jira] [Commented] (OFBIZ-8154) The entity description labels are considered not used by the Label Manager

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-8154) The entity description labels are considered not used by the Label Manager

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-8154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15481107#comment-15481107 ]

Jacques Le Roux commented on OFBIZ-8154:
----------------------------------------

Pierre, if you look for an AcctgTransType field in *form*.xml,*screen*.xml,*menu*.xml, files you will find none. But you will find several AcctgTransTypeId fields. Because AcctgTransType is an entity name and acctgTransTypeId is the PK of this entity. So you will always find the PK name in fields, not the entity name. The AcctgTransType.description.* labels stand for translation instances of acctgTransTypeId.

All the acctgTransTypeId fields use the FormFieldTitle_acctgTransTypeId label. Then there is a FormFieldTitle_acctgTransType label for which transaltions are almost the same than FormFieldTitle_acctgTransTypeId but is unused. Should we removed them (actually I can't see another reasons for the "Not used labels" option)? Not an easy answer, but I'd not be surprised to find that entity names translations are rarely, if ever, used. In OFBiz most of the time only the Ids are shown to users. Is that right? That's another question...

The .description. , and alike are labels, are overriding descriptions done in data files. Like for instance
{code}
<AcctgTransType acctgTransTypeId="AMORTIZATION" description="Amortization" hasTable="N" parentTypeId="INTERNAL_ACCTG_TRANS"/>
{code}
They add l10n to the possible initial data labels, eg
{code}
    <property key="AcctgTransType.description.AMORTIZATION">
        <value xml:lang="ar">الإطفاء</value>
        <value xml:lang="de">Amortisation</value>
        <value xml:lang="en">Amortization</value>
        <value xml:lang="fr">Amortissements</value>
        <value xml:lang="hi-IN">परिशोधन</value>
        <value xml:lang="it">Ammortamento</value>
        <value xml:lang="ja">償却(アモチゼーション)</value>
        <value xml:lang="nl">Amortisatie</value>
        <value xml:lang="pt-BR">Amortização</value>
        <value xml:lang="ro">Amortizare</value>
        <value xml:lang="ru">Амортизация</value>
        <value xml:lang="th">การตัดบัญชี</value>
        <value xml:lang="vi">Khấu hao</value>
        <value xml:lang="zh">贷款摊还</value>
        <value xml:lang="zh-TW">貸款攤還</value>
    </property>
{code}

I'd argue that even if those labels are not used OOTB they are always useful and should never be considered as "Not used" because they somehow are parts of the data, and not (only) destined to label fields (reports, etc.)

And BTW I created OFBIZ-8173 because I found that sometimes the labels are overriding better English labels existing in data files. Since other labels are translations of the English one, all are less accurate in this case.

The problem with labels is it takes an enourmous amount of time to get them right. And we know that by using English sentences in 1st place we are sometimes hindering translation, OK I'm totally out of subject :D, I stop there.

> The entity description labels are considered not used by the Label Manager
> --------------------------------------------------------------------------
>
>                 Key: OFBIZ-8154
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-8154
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework/webtools
>    Affects Versions: Trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Minor
>
> As I said in my r1759457 commit comment:
> bq. We have 5237 "Not Used Labels". I wondered if they were all real, I just checked some an indeed, they were not used.  But there are also a huge bunch of *.description.* labels which certainly make sense. I'll remove them from the "Only Not Used Labels" result in another Jira I'll create
> Here is the promised Jira



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)