[
https://issues.apache.org/jira/browse/OFBIZ-8179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15484256#comment-15484256 ]
Jacopo Cappellato commented on OFBIZ-8179:
------------------------------------------
Thanks for all your feedback and reviews.
I ended up committing a different version of my patch, in order to address Scott's comment: see rev. 1760376
With this fix I have removed the cyclic dependency between the two components; I didn't simplify the chain of calls required to get a connection from GeronimoTransactionFactory+DBCPConnectionFactory in order to maintain the flexibility to replace one of the two factories. We could revisit this discussion if/when we will have a measure that tells that direct calls improve the performance.
> Enhance DBCPConnectionFactory to implement a TransactionFactory and remove the geronimo component
> -------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-8179
> URL:
https://issues.apache.org/jira/browse/OFBIZ-8179> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: Trunk
> Reporter: Jacopo Cappellato
> Assignee: Jacopo Cappellato
> Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-8179.patch, TransactionConnectionFactory-before-after.png
>
>
> Made the DBCPConnectionFactory an implementation of TransactionFactory by moving the code from the GeronimoTransactionFactory.
> With this change the geronimo component is no more required.
> Without any functional change, this design simplifies greatly the calls and component dependencies because it removes a cyclic dependency between entity and geronimo components (see diagram attached that explain the architecture before and after this change).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Locked
