[jira] [Commented] (OFBIZ-8250) SvnInfo.ftl and GitInfo.ftl are not generated by default

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-8250) SvnInfo.ftl and GitInfo.ftl are not generated by default

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-8250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15502439#comment-15502439 ]

Jacques Le Roux commented on OFBIZ-8250:
----------------------------------------

After reading at http://freemarker.org/docs/ref_directive_include.html the ignore_missing description of this <#include attribute
bq. ignore_missing: When true, suppresses the error when the template to include is missing, instead <#include ...> will print nothing. When false, the template processing will stop with error if the template is missing. If you omit this option, then it defaults to false.
I thought that we could get rid of the empty files creation when building. But like Deepak [here|https://issues.apache.org/jira/browse/OFBIZ-7942?focusedCommentId=15409322&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15409322 ] I found that it's not working.
So I agree that the proposed patch is the best solution so far. I have reopened OFBIZ-7942 because I did not understood the problem there when I closed.

We need to report to Apache Freemarker (incubating) because as mentionned Deepak the ignore_missing attribute of the <#include directive does not work. When it will work we will use it and remove the need of creating empty files when running the build task.

I commit the proposed patch now, thanks for your patience :)

> SvnInfo.ftl and GitInfo.ftl are not generated by default
> --------------------------------------------------------
>
>                 Key: OFBIZ-8250
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-8250
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ALL APPLICATIONS
>    Affects Versions: Trunk
>            Reporter: Michael Brohl
>            Assignee: Michael Brohl
>            Priority: Minor
>             Fix For: Upcoming Branch
>
>         Attachments: Image 014.png, OFBIZ-8250-2.patch, OFBIZ-8250.patch
>
>
> The two files are not generated which results in an FTL stacktrace in the footer of the backend applications.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)